6f37120dc4
A paper needs its experiment figures, and a figure is not text: the bytes go to
MinIO and the sentence keeps a Markdown address. That is what keeps a sentence
one editable string — a picture moves between paragraphs by being cut and
pasted, and survives a template switch with the sentence it belongs to.
Three decisions carry the safety, and each is a way to serve something other
than what was uploaded:
* the key is the digest of the bytes, so uploading the same screenshot twice is
one object and the address can never come to mean a different picture — which
is what makes the year-long `immutable` cache header safe;
* the format is sniffed from the magic bytes, not read from the client's
`Content-Type` or filename, and SVG is refused because an uploaded SVG served
from this origin is stored XSS;
* serving is restricted to the key space this application writes, so
`GET /api/images/{key}` cannot become a browser for the rest of the bucket.
Images are served through the API rather than from a public bucket URL so a
sentence never embeds a host name — the LAN in development and the public
address later would otherwise disagree — and the bucket can stay private. The
object is streamed rather than read into memory, and the connection is released
when the reader stops.
Storage unconfigured is a 503 that names the missing variables, not a crash:
the writing path does not depend on the bucket.
`scripts/smoke_images.py` walks the whole thing: each accepted format, the
refusals (text, SVG, a mislabelled file, an empty file, a key we did not
write), and a sentence that carries a figure through the paper endpoints.
23 lines
572 B
Python
23 lines
572 B
Python
"""Aggregate router mounted under the configured API prefix."""
|
|
|
|
from fastapi import APIRouter
|
|
|
|
from app.api.routes import (
|
|
health,
|
|
images,
|
|
papers,
|
|
reference_tags,
|
|
references,
|
|
template_titles,
|
|
templates,
|
|
)
|
|
|
|
api_router = APIRouter()
|
|
api_router.include_router(health.router)
|
|
api_router.include_router(images.router)
|
|
api_router.include_router(papers.router)
|
|
api_router.include_router(reference_tags.router)
|
|
api_router.include_router(references.router)
|
|
api_router.include_router(template_titles.router)
|
|
api_router.include_router(templates.router)
|